Skip to content

Rules to follow

General

Only do the screens on the Figma design which are agreed upon. Do not do any new screens to prevent doing more work and delaying the deadline. If new screens have been added, let your manager know.
Every task that you do must go through your manager first.
Add multiple tasks on Jira to break down your work.
If you find any issues, make bug tickets under the bugs epic. They should show up in the backlog and not on the board. Any engineer can pick it up and start working on it.
If you find any inconsistencies with the designs and are confused, tell your manager about it.
Share nothing with people outside of the engineering team to keep internal things private.
Update the Jira tickets by moving them to the correct Jira column as the status of your tasks update
Follow the TDD development approach
Ensure that only 2 PRs at the max can be open at a time.
Get a PR out for your changes and fill up all sections of the PR template properly
Ensure that the tests in the PR pass and meet at least the 85% coverage threshold
Remove all Sonar issues if there are any
Wait for the Quality Gate to pass/fail. Get it to pass if it’s failing.
Write detailed instructions in the Jira tickets to help Solomon (the tester) test.

Post-PR routine

After all this, when your PR is finally ready, send a message in the Slack PR channel and tag 2 people to review your PR.
When merging your PR, do a normal merge and avoid the “squash and merge” option
Get a PR out to merge develop → UAT (if Solomon can’t test on develop). Wait for deployment to happen
Ask Solomon to test your changes and let you know about any bugs
Move corresponding tasks on
to “Testing”
Once testing is done, move corresponding tasks on
to done
Remove any of your stale remote and local branches

Steps for working on a hotfix:

Check out from the UAT branch. Call your new branch hotfix/<preferred-name>
Do your work on the branch
Once done and ready to push, raise your PR from your branch against UAT branch
Get your PRs approved after passing sonar.
Once deployed, your work is available on UAT environment where you can test
You can then deploy to preprod and prod

Reviewing PRs

Ensure that the PR is up to date with the develop branch
There should be 0 issues. If any have to be left, ensure that there’s a good reason for it.
If you find issues, write them as comments on the PR
If you find that the changes are fine, approve the PR
Message the author of the PR on GitHub/Slack to inform them that you’re done reviewing
Want to print your doc?
This is not the way.
Try clicking the ··· in the right corner or using a keyboard shortcut (
CtrlP
) instead.